Feature non behavior ophys nwb #2664
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating doc strings
|
Ahad Bawany seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Currently, the nwb modules for Ophys conversion are specialized for behavior ophys files. Unfortunately, there are some problems caused by this when trying to convert sessions which are non-behavior ophys. This PR seeks to handle this by creating similar modules which are optimized for non-behavior use cases. There are some project specific changes here that I can edit to help make the modules more universal, based on your feedback.
Addresses:
This addresses concerns of the OpenScope team, rather than any issues from the AllenSDK's ticket system. I can create a relevant ticket if that would be helpful?
Type of Fix:
Solution:
Validation:
Screenshots:
Unit Tests:
Script to reproduce error and fix:
Configuration details:
The OpenScope team has been using this modified version of the SDK to generate files for the dendrite coupling team without errors. These files also pass dandi validation metrics. The files are created using python 3.7 and the Allen Institute's slurm cluster.
Notes: